fix(assets-controllers): only seed mUSD on chains configured in NetworkController#8684
Draft
fix(assets-controllers): only seed mUSD on chains configured in NetworkController#8684
Conversation
…rkController `TokensController` previously seeded mUSD into `allTokens` for every chain in `MUSD_SUPPORTED_CHAIN_IDS` regardless of whether `NetworkController` had actually configured that chain. This caused state updates with chainIds that downstream subscribers (e.g. `TokenRatesController`) could not resolve. Look up the configured chain set via the new `NetworkController:getState` allowed action and intersect it with `MUSD_SUPPORTED_CHAIN_IDS` before seeding. The existing `NetworkController:networkAdded` and `NetworkController:stateChange` subscribers continue to re-run seeding so newly added supported chains are picked up automatically. The test harness now registers a `NetworkController:getState` handler returning all three supported chains by default, with an opt-in `configuredChainIds` option (incl. `null` for missing `networkConfigurationsByChainId`) to drive the new behavior in tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rkController
TokensControllerpreviously seeded mUSD intoallTokensfor every chain inMUSD_SUPPORTED_CHAIN_IDSregardless of whetherNetworkControllerhad actually configured that chain. This caused state updates with chainIds that downstream subscribers (e.g.TokenRatesController) could not resolve.Look up the configured chain set via the new
NetworkController:getStateallowed action and intersect it withMUSD_SUPPORTED_CHAIN_IDSbefore seeding. The existingNetworkController:networkAddedandNetworkController:stateChangesubscribers continue to re-run seeding so newly added supported chains are picked up automatically.The test harness now registers a
NetworkController:getStatehandler returning all three supported chains by default, with an opt-inconfiguredChainIdsoption (incl.nullfor missingnetworkConfigurationsByChainId) to drive the new behavior in tests.Explanation
References
Checklist